Log of changes necessary to compile launcher build

[Crafty]

Since it is almost a certainty that compilation requires editing Epic's code, I thought I would make a thread for tracking it. These are modifications I make as I encounter them, so if you have more to add or a better method please post them.

Feb 22nd
Commit: b8f722dec404dbff77a17623cb7dc90addf88337
Notes: https://wiki.unrealengine.com/Version_Notes_2017_02_22

---

..\UnrealTournament\UnrealTournament\Source\UnrealTournament\Private\UTLocalPlayer.cpp:6140

<<

    if (!ISocialModule::Get().GetFriendsAndChatManager(TEXT(""), true)->IsLoggedIn())
    {
        return;
    }

>>

#if WITH_SOCIAL
    if (!ISocialModule::Get().GetFriendsAndChatManager(TEXT(""), true)->IsLoggedIn())
    {
        return;
    }
#endif

---

This one popped up for me, but probably not necessary for most:

 

Spoiler

..\UnrealTournament\UnrealTournament\Source\UnrealTournament\Private\Slate\SKeyBind.h:6

<<

#include "../SUTStyle.h"
#include "../SUTUtils.h"

>>

#include "../Private/Slate/SUTStyle.h"
#include "../Private/Slate/SUTUtils.h"

[RattleSN4K3]

Good thread.

I noticed I also had to change the UTLocalPlayer.cpp part, but not the SKeyBind.h case (compiling DevEditor x64). Was it required on comiling?

[Crafty]

It was required for me using DevEd64, but I guess it could be to do with my plugin including it? Not sure.

[Crafty]

Does anyone know how to build after Visual Studio 2017 15.3? This is very annoying because there is no apparent way to downgrade VS2017 or download the old version..

The build fails with:

1>Module.Core.8_of_9.cpp
1>Module.DesktopPlatform.cpp
1>Module.Core.9_of_9.cpp
1>C:\Program Files (x86)\Windows Kits\8.1\include\um\shlobj.h(972): error C4768: __declspec attributes before linkage specification are ignored
1>C:\Program Files (x86)\Windows Kits\8.1\include\um\ShlObj.h(972): error C4768: __declspec attributes before linkage specification are ignored
1>C:\Program Files (x86)\Windows Kits\8.1\include\um\ShlObj.h(972): error C4768: __declspec attributes before linkage specification are ignored

Seems to be something to do with this:



https://docs.microsoft.com/en-us/cpp...rovements-2017

[warhead328]

I like this thread. Wondering if it could be made a sticky?

[Crafty]

Yeah, that would help because it tends to get buried.

As to the resolution of the problem with upgrading VS2017, I ultimately installed the old version from here: https://my.visualstudio.com/Download...0studio%202017 You need to sign up as a Wiindows Insider to access this I think.

Anyway, downgrading wasn't the end of my problems as I was met with more cryptic build errors. I ended up installing VS2015 to use that instead, which incidentally made VS2017 start working again. Some kind of dependency was obviously missing that was included with VS2015.